chore(e2e-tests): skip j int test as it isn't recognized on CI #7105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a flaky E2E test by disabling the assertion for the unrecognized token “j int” in the Data Modeling tab test on CI.
- Commented out the
expect(text).to.include('j int')assertion. - Added inline comments explaining why the assertion is disabled.
Comments suppressed due to low confidence (1)
packages/compass-e2e-tests/tests/data-modeling-tab.test.ts:327
- [nitpick] Consider replacing the commented assertion with a dedicated
it.skiportest.skipfor 'j int' so the test suite clearly reports skipped tests rather than silently omitting assertions.
// Disabled as it's not recognized correctly by tesseract.js at the moment.
Comment on lines
+328
to
329
| // expect(text).to.include('j int'); | ||
| // it does not correctly recognize `iString` and only returns `String`. |
There was a problem hiding this comment.
Add a TODO or reference an issue ticket here to re-enable this assertion once Tesseract.js correctly recognizes 'j int', helping future maintainers track the fix.
Suggested change
| // expect(text).to.include('j int'); | |
| // it does not correctly recognize `iString` and only returns `String`. | |
| // TODO: Re-enable the following assertion once Tesseract.js correctly recognizes 'j int'. | |
| // expect(text).to.include('j int'); |
mabaasit
approved these changes
Jul 10, 2025
Anemy
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.